Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.0.x] Alerting: No longer silence paused alerts during legacy migration #71761

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[v10.0.x] Alerting: No longer silence paused alerts during legacy migration #71761

merged 1 commit into from
Jul 17, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 8c6cdf5 from #71596

Now that we have alert pausing in UA and paused legacy alerts are migrated to paused UA alert rules, we no longer need to silence them during migration.

Docs updated to remove text: Silences (expiring after one year) are created for all paused dashboard alerts.

Fixes #71595

Special notes for your reviewer:

Backporting is technically optional here, but backporting simple legacy migration changes as far back as possible is best to improve migration experience without requiring instance upgrades.

Please check that:

@JacobsonMT @grafana-delivery-bot
Alerting: No longer silence paused alerts during legacy migration (#7…
203c9ee 
…1596)

* Alerting: No longer silence paused alerts during legacy migration

Now that we migrate paused legacy alerts to paused UA alert rules, we no longer need to silence them.

(cherry picked from commit 8c6cdf5)
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Jul 17, 2023
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/alerting Grafana Alerting area/backend area/backend/db/migration backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project labels Jul 17, 2023
@JacobsonMT JacobsonMT enabled auto-merge (squash) July 17, 2023 13:47
@JacobsonMT JacobsonMT merged commit f9a8e0a into v10.0.x Jul 17, 2023
@JacobsonMT JacobsonMT deleted the backport-71596-to-v10.0.x branch July 17, 2023 13:49
@zerok zerok modified the milestones: 10.0.x, 10.0.3 Jul 18, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 26, 2023
Merged
@jdbaldry jdbaldry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobsonMT JacobsonMT JacobsonMT approved these changes

@brendamuir brendamuir Awaiting requested review from brendamuir brendamuir is a code owner

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend/db/migration area/backend backport A backport PR product-approved Pull requests that are approved by product/managers and are allowed to be backported type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
Alerting
Archived in project
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@JacobsonMT @zerok