Tempo: Highlight errors in TraceQL query #74697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizio-grafana
added
add to changelog
datasource/Tempo
no-backport
fabrizio-grafana
changed the title
fabrizio-grafana
changed the title
adrapereira
requested changes
Sep 18, 2023
|
Sure, let's improve it a little more. Currently this feature works as in the LogQL editor, but we can definitely make it better, I'll work on it! |
|
@adrapereira let me know if you think we are going in the right direction. We can then improve the details, such as changing a little bit the error messages—e.g., instead of "Invalid comparison operator", have something like "Expected comparison operator, received X instead". |
adrapereira
approved these changes
Oct 3, 2023
bergquist
added a commit
that referenced
this pull request
Oct 3, 2023
* main: Docs: Fix link to developing plugins (#75816) Fix: visualization vs visualisation in feature description (#75895) Chore: Bump storybook 7.4.5 (#75652) Correlations: Add an editor in Explore (#73315) i18n: dashboard settings (#75854) Tempo: Highlight errors in TraceQL query (#74697) Datasources: Filter plugin errors to only show datasource plugins (#74339) Fix sticky header issue (#75710) Transformations: Extended support for variables in filter by name (#75734) Alerting: Fix being redirected to list view when clicking Save rule button (#75510) Tracing: Standardize on otel tracing (#75528) Fix developer links and newly discovered spelling errors (#75875) i18n: Mark up GeneralSettings for translations (#75827) DockedMegaMenu: Refactor and rename to simplify (#75872) sql: numeric inputs: use it's own simple implementation (#74904)
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Highlight errors * Chores * Refactor * Address PR comments * Refactoring * Fix * Handle another case * Handle more use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, when a TraceQL query contains syntax errors, it just fail when submitted to Tempo. No feedback is given to the user before submitting it, and the error message returned by Tempo is not particularly user friendly.
To help users understand why their query failed, we want to highlight the parts of the query that might be wrong due to syntax errors. This should simplify the user experience and the usage of TraceQL.
Example of outcome after changes:
Fixes #74264