Alerting: Fix export of notification policy to JSON #78021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON version of an exported Notification Policy now inline correctly the policy in the same way the Yaml version does.
rvillablanca
requested review from
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
|
|
grafana-pr-automation
bot
added
area/backend
pr/external
yuri-tceretian
approved these changes
Nov 30, 2023
yuri-tceretian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
It exports correctly a Notification Policy in json format, so that it can be provisioned correctly.
Why do we need this feature?
Because currently it is not possible to export the default Notification Policy and then provision it in json file format, this due to the Policy fields are not inlined, unlike the yaml format.
Who is this feature for?
Any Grafana user I guess
Which issue(s) does this PR fix?:
Fixes #78020
Before this PR
The JSON version includes the
Policyattribute which is not included in the Yaml version.Exported Notification Policy - Json
Exported Notification Policy - Yaml
With this PR
The JSON verion now inlines the fields correctly
Special notes for your reviewer:
Please check that: