-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformations: Move transformation addition into drawer #78299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try a 2 column layout for the transformation cards, just to try a list view that is not so dense |
Been playing with the layout a bit currently tricky though without changing up the card style. Mainly it's because the drawer width is based on the viewport so it doesn't have static sizes (with a deprecated width property as well). I'm thinking the approach for this would be expand/collapse controls mentioned here #77483 (comment). I'm not against changing up the card styles as well. What do you think @torkelo? |
Did fix the button spacing as well 😄 |
onSearchKeyDown: KeyboardEventHandler<HTMLInputElement>; | ||
onTransformationAdd: Function; | ||
suffix: ReactNode; | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way around these any
s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been thinking about this one. The reason that it's any is that transformations can have, well, any structure for their options 😂 . This type had been like this before, and we can look at typing it out but it would probably require a fair amount of in-depth effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this looks awesome!
What is this feature?
Elaboration on #77483. Was running into issues because the interleaved nature of the transformRedesign flag usage was making it difficult to clearly separate new and old interactions. This adds transformation to drawer but also moves the transformation pickers (new and old) into separate components.
Which issue(s) does this PR fix?:
Fixes #74197
Please check that: