Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeseries: Remove cursor sync when x is not time #78496

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Timeseries: Remove cursor sync when x is not time #78496

merged 2 commits into from
Nov 22, 2023

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Nov 21, 2023 •
edited by nmarrs

This PR removes cursor sync when x is not time.

cursor_sync.mov

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added this to the 10.3.x milestone Nov 21, 2023
@adela-almasan adela-almasan self-assigned this Nov 21, 2023
@adela-almasan adela-almasan marked this pull request as ready for review November 21, 2023 18:12
@adela-almasan adela-almasan requested a review from a team as a code owner November 21, 2023 18:12
@adela-almasan adela-almasan requested review from Develer and nmarrs and removed request for a team November 21, 2023 18:12
@adela-almasan adela-almasan changed the title [WIP] Timeseries: Cursor sync updates Timeseries: Cursor sync updates Nov 21, 2023
@drew08t drew08t self-requested a review November 22, 2023 19:55
nmarrs
nmarrs approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (including edge case of having time series panels with cursor sharing alongside a trend panel) and this LGTM 🚀

Screen.Recording.2023-11-22.at.2.18.08.PM.mov

@adela-almasan adela-almasan changed the title Timeseries: Cursor sync updates Timeseries: Remove cursor sync when x is not time Nov 22, 2023
@adela-almasan adela-almasan merged commit 5b851d7 into main Nov 22, 2023
41 checks passed
@adela-almasan adela-almasan deleted the cursor_sync_update branch November 22, 2023 22:23
@nmarrs nmarrs mentioned this pull request Nov 22, 2023
Closed
3 tasks
eleijonmarck pushed a commit that referenced this pull request Nov 27, 2023
@adela-almasan @eleijonmarck
Timeseries: Remove cursor sync when x is not time (#78496)
f778484
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

@Develer Develer Awaiting requested review from Develer Develer is a code owner automatically assigned from grafana/dataviz-squad

@drew08t drew08t Awaiting requested review from drew08t

Assignees

@adela-almasan adela-almasan

Labels
add to changelog area/frontend area/panel/candlestick area/panel/timeseries The main time series Graph panel area/panel/trend no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adela-almasan @nmarrs @aangelisc