Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Improve groups claim setup docs for AzureAD #78791

Merged
merged 15 commits into from
Dec 7, 2023
Merged

Auth: Improve groups claim setup docs for AzureAD #78791

merged 15 commits into from
Dec 7, 2023

Conversation

mgyongyosi
Copy link
Contributor

@mgyongyosi mgyongyosi commented Nov 29, 2023 •
edited
Loading

What is this feature?
This PR extends the groups setup docs for the AzureAD provider.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@mgyongyosi mgyongyosi added type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project area/auth area/auth/oauth add to changelog backport v10.2.x labels Nov 29, 2023
@mgyongyosi mgyongyosi added this to the 10.3.x milestone Nov 29, 2023
@mgyongyosi mgyongyosi requested a review from chri2547 as a code owner November 29, 2023 09:33
eleijonmarck
eleijonmarck approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@eleijonmarck eleijonmarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice update

chri2547
chri2547 requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions, please review to ensure I didn't change the technical meaning of what you wrote. I'd like to have another review after you accept suggestions. Thank you very much for this contribution! We really appreciate it.

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
mgyongyosi and others added 4 commits November 29, 2023 16:55
@mgyongyosi @chri2547
Apply suggestions from code review
e113bb4 
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@mgyongyosi @chri2547
Update docs/sources/setup-grafana/configure-security/configure-authen…
24b970e 
…tication/azuread/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@mgyongyosi @chri2547
Update docs/sources/setup-grafana/configure-security/configure-authen…
6001e7d 
…tication/azuread/index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@mgyongyosi
Update the groups and app roles documentation
978d5e1
@mgyongyosi mgyongyosi requested a review from chri2547 November 30, 2023 15:20
@mgyongyosi mgyongyosi requested a review from lwandz13 December 4, 2023 13:09
chri2547
chri2547 requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Some suggestions

docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
@mgyongyosi @chri2547
Apply suggestions from code review
71bb0d6 
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@mgyongyosi mgyongyosi requested a review from chri2547 December 5, 2023 11:41
lwandz13
lwandz13 requested changes Dec 5, 2023
View reviewed changes
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md Outdated Show resolved Hide resolved
mgyongyosi and others added 2 commits December 6, 2023 12:19
@mgyongyosi @lwandz13
Apply suggestions from code review
1121dff 
Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>
@mgyongyosi
Changes
d2de37c
@mgyongyosi mgyongyosi requested a review from lwandz13 December 6, 2023 12:19
lwandz13
lwandz13 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@lwandz13 lwandz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@mgyongyosi mgyongyosi merged commit 9f93063 into main Dec 7, 2023
8 checks passed
@mgyongyosi mgyongyosi deleted the docs/azuread-groups branch December 7, 2023 14:31
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Dec 7, 2023
Merged
3 tasks
grafana-delivery-bot bot pushed a commit that referenced this pull request Dec 7, 2023
@mgyongyosi @grafana-delivery-bot
Auth: Improve groups claim setup docs for AzureAD (#78791)
32b2156 
* Improve groups claim setup docs

* Improve the GroupMember.Read.All perm docs

* Apply suggestions from code review

* Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

* Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

* Update the groups and app roles documentation

* Update

* Split long list to separate sections

* fix anchor

* Apply suggestions from code review

* Address other comments, fix anchors

* Address other comments, lint

* Apply suggestions from code review

* Changes

* final adjustments

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>
(cherry picked from commit 9f93063)
mgyongyosi added a commit that referenced this pull request Dec 7, 2023
@grafana-delivery-bot @mgyongyosi
[v10.2.x] Auth: Improve groups claim setup docs for AzureAD (#79227)
a8e8cb9 
Auth: Improve groups claim setup docs for AzureAD (#78791)

* Improve groups claim setup docs

* Improve the GroupMember.Read.All perm docs

* Apply suggestions from code review

* Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

* Update docs/sources/setup-grafana/configure-security/configure-authentication/azuread/index.md

* Update the groups and app roles documentation

* Update

* Split long list to separate sections

* fix anchor

* Apply suggestions from code review

* Address other comments, fix anchors

* Address other comments, lint

* Apply suggestions from code review

* Changes

* final adjustments

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>
(cherry picked from commit 9f93063)

Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eleijonmarck eleijonmarck eleijonmarck approved these changes

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

@chri2547 chri2547 chri2547 approved these changes

@lwandz13 lwandz13 lwandz13 approved these changes

@navbahl navbahl Awaiting requested review from navbahl

@MattiasSegerdahl MattiasSegerdahl Awaiting requested review from MattiasSegerdahl

Assignees
No one assigned
Labels
add to changelog area/auth/oauth area/auth backport v10.2.x type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.
7 participants
@mgyongyosi @eleijonmarck @IevaVasiljeva @chri2547 @navbahl @lwandz13 @aangelisc