Elasticsearch: Fix showing of logs when __source is log message field
#80804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
type/bug
add to changelog
backport v10.3.x
matyax
reviewed
Jan 18, 2024
| ], | ||
| "testtime": "09/02/2023" | ||
| } | ||
| "{\"abc\":null,\"counter\":81,\"float\":10.911972180833306,\"is_true\":true,\"label\":\"val3\",\"line\":\"log text [106619125]\",\"location\":\"-42.73465234425797, -14.097854057104112\",\"lvl\":\"info\",\"nested_field.internal.nested\":\"value1\",\"shapes\":[{\"type\":\"triangle\"},{\"type\":\"triangle\"},{\"type\":\"triangle\"},{\"type\":\"square\"}],\"testtime\":\"09/02/2023\"}", |
There was a problem hiding this comment.
I understand here is the _source change from json to string, right?
matyax
approved these changes
Jan 18, 2024
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
…ld (#80804) Elasticsearch: Fix showing of logs whe __source is log message field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Logs panel currently presents the first string data frame field as the log message. However, when the Elasticsearch response undergoes processing through the backend, we set the
_sourcefield to the type of*json.RawMessagewhich is on frontend represented asother. Consequently, it is skipped, and the subsequent field is displayed as the log message.This PR addresses the problem by ensuring that for log queries, the
__sourceis set as the string results, resolving the issue.Fixed:
Current main:
Related to: #78790
To test:
__source__sourcefield