Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Graphana not able to use fields from nested objects with annotations pulled from Elasticsearch #830

Merged
merged 2 commits into from
Sep 20, 2014

Conversation

igreg
Copy link
Contributor

@igreg igreg commented Sep 19, 2014

This adds support for title and text fields like "@fields.my_value" which are returned by Elastichsearch as nested objects. Fixes issue #829

Extreme values that go beyond the screen resolution are very likely to be misplaced. This is a simple workaround. A better solution would be to improve the code placing the tooltip and make it handle tooltips containing more content than they can safely display.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) when pulling 06ec91c on notonthehighstreet:master into 563dd89 on grafana:master.

@torkelo
Copy link
Member

torkelo commented Sep 19, 2014

Looks great, thanks!

Please sign the CLA, http://grafana.org/docs/contributing/cla.html

@igreg
Copy link
Contributor Author

igreg commented Sep 19, 2014

CLA signed

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants