Added requests/sec(throughput) #11694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergquist
requested changes
Apr 23, 2018
public/app/core/utils/kbn.ts
Outdated
| @@ -948,6 +949,7 @@ kbn.getUnitFormats = function() { | |||
| text: 'throughput', | |||
| submenu: [ | |||
| { text: 'ops/sec (ops)', value: 'ops' }, | |||
| { text: 'requets/sec (rps)', value: 'rps' }, | |||
There was a problem hiding this comment.
This conflicts with reads/sec
There was a problem hiding this comment.
I have now changed from rps to reqps
bergquist
approved these changes
Apr 24, 2018
|
Thank you for contributing! |
mjtrangoni
reviewed
Apr 24, 2018
| @@ -948,6 +949,7 @@ kbn.getUnitFormats = function() { | |||
| text: 'throughput', | |||
| submenu: [ | |||
| { text: 'ops/sec (ops)', value: 'ops' }, | |||
| { text: 'requets/sec (rps)', value: 'reqps' }, | |||
There was a problem hiding this comment.
@bergquist This should be request instead of requets
There was a problem hiding this comment.
@mjtrangoni Thanks for seeing this.
Can I changed this PR or do I have to create a new PR?
It should have been requests/sec
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9630