Quota: Makes LDAP + Quota work for the first login of a new user #21949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was missing for ldap_login which means that the first signup failed for users with LDAP+quota enabled. There's also potential cases where we can't provide a request context (background jobs) which is also covered, but needs a refactoring.
marefr
approved these changes
Feb 5, 2020
|
@marefr I think that might be hard, a lot of the qutoas need a better understanding of what will happen than is available in the http layer. It would definitely be nice to make it cleaner if possible though. |
alexanderzobnin
added a commit
that referenced
this pull request
Feb 6, 2020
alexanderzobnin
added a commit
that referenced
this pull request
Feb 6, 2020
* Change log 6.6.1 * Add PR co-authors * fix label type for PR #21949 Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes bugs related to quota's with LDAP. The first login for a user with LDAP and Quotas enabled would always fail.
Which issue(s) this PR fixes:
Fixes #21947
Special notes for your reviewer: