Image Rendering: Remove PhantomJS support #23460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes PhantomJS. Remove direct link rendered image e2e smoke test for now. Ref #13802
Co-Authored-By: Kyle Brandt <kyle@grafana.com> Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>
marefr
requested review from
kylebrandt,
aknuds1,
torkelo and
bergquist
and removed request for
a team
oddlittlebird
suggested changes
Apr 15, 2020
Co-Authored-By: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
oddlittlebird
approved these changes
Apr 15, 2020
bergquist
added a commit
to bergquist/grafana
that referenced
this pull request
Apr 16, 2020
* master: Linting fixes for provisoning (grafana#23600) Image Rendering: Remove PhantomJS support (grafana#23460) Storybook: Organizing (grafana#23572) @grafana/ui: Remove ColorPallete component (grafana#23592)
bergquist
added a commit
that referenced
this pull request
Apr 17, 2020
* master: (139 commits) SAML Role and Team sync (open source part) (#23391) Transformers: fixes column names generated by seriesToColumn transformer (#23642) Table: add a select option when multiple tables exist (#23545) Tabs: adds counter component (#23548) UX: Minor style tweaks and fixes (#23614) Modals: Fixed alignment in header (#23618) revent optional event arg change (#23622) Build: Stricter linting should break the build (#23606) Docs: update users API (#23570) Explore: Prevents sizing issue when split (#23596) @grafana/ui: Various smaller Icon updates (#23588) Because alpine uses musl instead of libc, the e2e/cypress was not compatible (#23602) Backend Plugins: Discard logged messages from logger named stdio (#23601) Fixed share json (#23607) Linting fixes for provisoning (#23600) Image Rendering: Remove PhantomJS support (#23460) Storybook: Organizing (#23572) @grafana/ui: Remove ColorPallete component (#23592) Docs: Change header levels of last three sections (#23587) CircleCI: Upgrade the build pipeline tool (#23595) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes PhantomJS
Which issue(s) this PR fixes:
Closes #13802
Special notes for your reviewer:
Improve UX for share panel/direct link rendered image when there are no renderer available/installed will be handled in a follow up PR.