GraphPanel: Make legend values clickable series toggles #25581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
requested review from
a team,
mckn and
tskarhed
and removed request for
a team
torkelo
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
onLabelClick()handler by passing it to the LegendValue. applies to both table and non-table legends.before
after
Which issue(s) this PR fixes:
Fixes #25402
Special notes for your reviewer:
This patch does have an effect on text selection for legend values (double-click, drag-to-select). These compound events start as clicks so the series toggles during the operation. This matches the behavior of the legend labels on click, so no change to this behavior was made.
