Alerting: Ensuring LINE Notify notifications are sent for all alert states #27639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldkubota
requested review from
papagian and
marefr
and removed request for
a team
|
|
|
Thanks. Please sign the Contributor License Agreement (CLA). We'll not review this until it's signed. |
marefr
added
area/alerting/notifications
wbrowne
approved these changes
Sep 24, 2020
wbrowne
changed the title
Merged
ryantxu
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Get Alerts AND OKs for LINE Notify * Get Alerts AND OKs for LINE Notify * Get Alerts AND OKs for LINE Notify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
LINE Notifications only work for alerts. The "OK" notifications does not get sent. Other notifiers (email, Slack) do send both "[Alerting]" as well as "[OK]" notifications.
Which issue(s) this PR fixes:
Fixes LINE Notifications now OK notifications too. Also the notification contains the "[Alerting]" resp. "[OK]" like email and Slack do.
Fixes specific issue #12781
Special notes for your reviewer:
I compared other notifiers and none seem to have the problem of missing "OK" notifications. I guess LINE is not used a lot.