-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency: Adds Indonesian IDR currency #28363
Currency: Adds Indonesian IDR currency #28363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution. You'll need to sign the contributor license agreement before this can be merged, however
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @kaydelaney, splendid work with this. You need to sign the CLA so we can merge this into master.
Also, I think you can use custom data units for this https://grafana.com/blog/2020/01/27/grafana-v6.6-released/#custom-data-units
sorry I am new here. I hope with this merge can help Indonesian user easy to use their own currency with the option that already exists |
@hiddenrebel -- look up in this thread and you will see a post from the CLA assistant, it will look like: Click on the part that says "not signed" and you will go to a form that lets you fill it out thanks! |
|
I think I understand why, the commit was commited by Muhammad Hendry and your github user is @hiddenrebel. You need to add the email adress for Muhammad Hendry to your github user. Thank you |
Awesome, thank you for your kind 👍 |
What this PR does / why we need it:
Add new option for Indonesian IDR currency
And Fix typo
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: