CloudWatch Logs: Fix crash when no region is selected #37639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
requested review from
a team,
joshhunt,
vickyyyyyyy and
davkal
and removed request for
a team
aocenas
added
datasource/CloudWatch Logs
aocenas
requested review from
a team,
zoltanbedi and
ifrost
and removed request for
joshhunt,
vickyyyyyyy,
davkal,
a team and
zoltanbedi
aocenas
added
old backport v8.0.x
Clarity-89
approved these changes
Aug 6, 2021
grafanabot
pushed a commit
that referenced
this pull request
Aug 6, 2021
(cherry picked from commit e9c032f)
grafanabot
pushed a commit
that referenced
this pull request
Aug 6, 2021
(cherry picked from commit e9c032f)
aocenas
added a commit
that referenced
this pull request
Aug 6, 2021
aocenas
added a commit
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @jongyllen this only happens on prod (can be seen on play.grafana.com). Here we conditionally add error property in response
grafana/pkg/api/response/response.go
Line 193 in 93d0f71
due to that the error handling on frontend expected string but on prod it got object which then crashed during rendering.