Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables: Fix repeating panels for on time range changed variables #42828

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Variables: Fix repeating panels for on time range changed variables #42828

merged 1 commit into from
Dec 8, 2021

Conversation

hugohaggmark
Copy link
Contributor

@hugohaggmark hugohaggmark commented Dec 7, 2021 •
edited
Loading

What this PR does / why we need it:
This PR makes sure to process repeats whenever a variable has changed because of a changed value or if the time range has changed. The PR also refactors some implicit undefined behaviour and introduces a more readable approach (#41717 (comment)).

Which issue(s) this PR fixes:
Fixes #42761

Special notes for your reviewer:
Follow the instructions in the issue to reproduce.

@hugohaggmark hugohaggmark added this to the 8.3.1 milestone Dec 7, 2021
@hugohaggmark hugohaggmark requested a review from a team December 7, 2021 12:47
@hugohaggmark hugohaggmark self-assigned this Dec 7, 2021
@hugohaggmark hugohaggmark requested review from joshhunt, ashharrison90 and kaydelaney and removed request for a team and joshhunt December 7, 2021 12:47
@hugohaggmark hugohaggmark merged commit 7a99b06 into main Dec 8, 2021
@hugohaggmark hugohaggmark deleted the hugoh/issue-process-repeats branch December 8, 2021 07:11
@grafanabot grafanabot mentioned this pull request Dec 8, 2021
Merged
grafanabot pushed a commit that referenced this pull request Dec 8, 2021
@hugohaggmark @grafanabot
Variables: Fix repeating panels for on time range changed variables (#…
cd866af 
…42828)

(cherry picked from commit 7a99b06)
hugohaggmark added a commit that referenced this pull request Dec 8, 2021
@grafanabot @hugohaggmark
Variables: Fix repeating panels for on time range changed variables (#…
2d34b9f 
…42828) (#42864)

(cherry picked from commit 7a99b06)

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
ryantxu pushed a commit that referenced this pull request Dec 8, 2021
@hugohaggmark @ryantxu
Variables: Fix repeating panels for on time range changed variables (#…
e47d66a 
…42828)
@ashharrison90 ashharrison90 mentioned this pull request Dec 21, 2021
Closed
@hugohaggmark hugohaggmark mentioned this pull request Dec 22, 2021
Merged
@bijwaard bijwaard mentioned this pull request Jan 10, 2022
Closed
@zuchka zuchka mentioned this pull request Feb 1, 2022
Closed
@jtorkkel jtorkkel mentioned this pull request Mar 16, 2022
Closed
@day4me day4me mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 was automatically assigned from grafana/grafana-frontend-platform

@kaydelaney kaydelaney Awaiting requested review from kaydelaney

Assignees

@hugohaggmark hugohaggmark

Labels
add to changelog area/dashboard/templating area/frontend area/templating/repeating Repeating panels or rows backport v8.3.x Mark PR for automatic backport to v8.3.x type/bug
Projects
None yet
Milestone
8.3.3
Development

Successfully merging this pull request may close these issues.

Variable not updating when time range changes
3 participants
@hugohaggmark @joshhunt @grafanabot