Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release k6chaijs@4.5.0.1 #139

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Release k6chaijs@4.5.0.1 #139

merged 4 commits into from
Sep 6, 2024

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Sep 5, 2024

Description

Release k6chaijs@4.5.0.1. This version adds support for `exitOnError" option. For more details, please see grafana/k6-jslib-k6chaijs@8eddf2d.

  • Use a meaningful title for the Pull Request. Include the name of the jslib added/modified.
  • Fill the description section of the Pull Request.
  • Test the change in your code, and ensure the npm run test command succeeds.
  • Run yarn run generate-homepage locally and verify the new homepage /lib/index.html file looks legit.

If publishing a new version of an existing jslib:

  • The Pull Request is labeled with the version bump label.
  • The Pull Request adds a /lib/{jslib_name}/{desired_version} folder.
  • The Pull Request adds a /lib/{jslib_name}/{desired_version}/index.js file containing the jslib's code bundle.
  • The Pull Request updates the supported.json file to contain an entry for the newly added jslib version, as in the following example:
{
  "my-lib": [
    "1.0.2",
    // Use semantic versioning
    "{desired_version}"
  ]
}
  • The Pull Request adds the relevant tests to the /tests/basic.js and /tests/testSuite.js files to ensure that the new version of the jslib is importable and runnable by k6.

@Blinkuu Blinkuu self-assigned this Sep 5, 2024
@Blinkuu Blinkuu marked this pull request as ready for review September 5, 2024 11:19
@Blinkuu Blinkuu requested review from a team as code owners September 5, 2024 11:19
@Blinkuu Blinkuu requested review from mstoykov, joanlopez, w1kman and allansson and removed request for a team September 5, 2024 11:19
Copy link

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering, if we have added a new configuration/behavior, shouldn't it been v4.5.1, or even v4.6.0? 🤔 Or this doesn't follow some sort of semantic versioning?

@Blinkuu
Copy link
Contributor Author

Blinkuu commented Sep 5, 2024

I'm just wondering, if we have added a new configuration/behavior, shouldn't it been v4.5.1, or even v4.6.0? 🤔 Or this doesn't follow some sort of semantic versioning?

@joanlopez In the README, we can see that our version should follow the chai version (see here). Since chai versions use only MAJOR, MINOR and PATCH numbers (in other words, the semver is in X.Y.Z format) I figured that bumping the fourth number makes sense to indicate the change in our functionality.

@Blinkuu Blinkuu requested a review from joanlopez September 5, 2024 13:40
@joanlopez
Copy link

I'm just wondering, if we have added a new configuration/behavior, shouldn't it been v4.5.1, or even v4.6.0? 🤔 Or this doesn't follow some sort of semantic versioning?

@joanlopez In the README, we can see that our version should follow the chai version (see here). Since chai versions use only MAJOR, MINOR and PATCH numbers (in other words, the semver is in X.Y.Z format) I figured that bumping the fourth number makes sense to indicate the change in our functionality.

Ah, ah! Right! My mistake, and now that you mentioned, I remember to have the same thought and reading the same comment, so double fault! Apologies! 🙏🏻

@Blinkuu Blinkuu merged commit c1a5830 into main Sep 6, 2024
4 checks passed
@Blinkuu Blinkuu deleted the release-new-version-k6chaijs branch September 6, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants