Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the number of passed checks when all the checks pass #22

Open
mstoykov opened this issue Jan 11, 2021 · 3 comments
Open

Show the number of passed checks when all the checks pass #22

mstoykov opened this issue Jan 11, 2021 · 3 comments

Comments

@mstoykov
Copy link
Contributor

This was reported in the community forum and it will be possible to be done by the users themself after grafana/k6#1768 , but maybe it is good idea to be included by default.

@na-- na-- transferred this issue from grafana/k6 Jan 27, 2021
@na--
Copy link
Member

na-- commented Jan 27, 2021

As I mentioned in grafana/k6#1806, in k6 v0.31.0 we'll adopt the latest version of the JS-based summary generation code from jslib.k6.io (originally submitted in #20), now that we have handleSummary(). So I've moved this issue to the jslib repo, given that any change requests for the default text summary k6 outputs should be opened here.

In this case, we could easily add another option to generateTextSummary() that would cause k6 to always show the number of passed checks:
https://github.com/loadimpact/jslib.k6.io/blob/07faf739629462571584fefcf85478dad64993c9/lib/k6-summary/0.0.1/index.js#L24-L29

https://github.com/loadimpact/jslib.k6.io/blob/07faf739629462571584fefcf85478dad64993c9/lib/k6-summary/0.0.1/index.js#L374-L375

https://github.com/loadimpact/jslib.k6.io/blob/07faf739629462571584fefcf85478dad64993c9/lib/k6-summary/0.0.1/index.js#L70

@simskij
Copy link
Contributor

simskij commented Apr 22, 2021

As I mentioned in k6io/k6#1806, in k6 v0.31.0 we'll adopt the latest version of the JS-based summary generation code from jslib.k6.io (originally submitted in #20), now that we have handleSummary(). So I've moved this issue to the jslib repo, given that any change requests for the default text summary k6 outputs should be opened here.

Out of curiosity (I haven't read the other issues in detail so it might already be stated somewhere there); what would happen if you run k6 somewhere where you don't have WAN access? Is it bundled in the k6 binary or would it just fail/not print anything?

@na--
Copy link
Member

na-- commented Apr 22, 2021

It is bundled in the binary. The PR with moving the the JS summary (and a bunch of other things... 😅 ) is already done (grafana/k6#1975), we just won't merge it until we release k6 v0.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants