-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document gRPC stram message's metadata
#1735
Conversation
metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olegbespalov thanks for opening the PR! I made some suggestions to make this more readable, let me know if it makes sense. 🙇
docs/sources/next/javascript-api/k6-net-grpc/stream/stream-on.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-net-grpc/stream/message-metadata.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-net-grpc/stream/message-metadata.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-net-grpc/stream/message-metadata.md
Outdated
Show resolved
Hide resolved
ed97368
to
74c2244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now, but we likely should rewrit it with the handler having it's own page
docs/sources/next/javascript-api/k6-net-grpc/stream/stream-on.md
Outdated
Show resolved
Hide resolved
74c2244
to
3345039
Compare
3345039
to
e751e1c
Compare
What?
This PR does two things:
Checklist
npm start
command locally and verified that the changes look good.docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)
grafana/k6#3801