Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix Helm linting and testing #419

Closed
yorugac opened this issue Jun 14, 2024 · 1 comment
Closed

CI: fix Helm linting and testing #419

yorugac opened this issue Jun 14, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed maintenance
Milestone

Comments

@yorugac
Copy link
Collaborator

yorugac commented Jun 14, 2024

CI workflows for linting and testing Helm should be enabled for all PRs that include changes to chart's folder. Those workflows are set up in that way now; however, it appears that in case of third-party PR, the workflow fails:

Image

Image

It might be the branch is not being pulled correctly, given the renaming GA is doing automatically. Or there might be some error with how ct is being called.

@yorugac
Copy link
Collaborator Author

yorugac commented Aug 21, 2024

Hopefully fixed with the PRs:
#444
#447
#448
#449

Tested for external PRs here:
#445
#446

@yorugac yorugac closed this as completed Aug 21, 2024
@yorugac yorugac added this to the 0.17 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed maintenance
Projects
None yet
Development

No branches or pull requests

1 participant