Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make k6-curl container resources configurable #502

Open
NT-florianernst opened this issue Dec 5, 2024 · 1 comment
Open

Make k6-curl container resources configurable #502

NT-florianernst opened this issue Dec 5, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NT-florianernst
Copy link

Feature Description

Hello all,

in our clusters we have team namespaces configured with a LimitRange specifying a maxLimitRequestRatio of 5, cf. OpenShift Container Limits.

However, it seems the k6-operator hardcodes a memory ratio of 100, cf. pkg/resources/containers/curl_start.go (209715200 for limits and 2097152 for requests), and as a result the starter pod cannot start in our team namespaces.

Please make these resources actually configurable. The TestRun CRD already allows setting the resources, but they are not used.

Thanks for considering,
Flo

Suggested Solution (optional)

Most probably a structure similar to handling the Runner resources can be used.

Already existing or connected issues / PRs (optional)

No response

@NT-florianernst NT-florianernst added the enhancement New feature or request label Dec 5, 2024
@yorugac
Copy link
Collaborator

yorugac commented Dec 15, 2024

Hi @NT-florianernst, thanks for bringing this up! You're right: this should be a relatively small fix in logic, given that one can already specify resources for jobs 👍

@yorugac yorugac added the good first issue Good for newcomers label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants