Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Load Profile options component #24

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: Add Load Profile options component #24

merged 5 commits into from
Jul 10, 2024

Conversation

2Steaks
Copy link
Collaborator

@2Steaks 2Steaks commented Jul 9, 2024

Closes https://github.com/grafana/k6-cloud/issues/2504

This PR adds the LoadProfile component

  • We do not include the concept of scenarios
  • We have dropped the ramping VU chart (for now)

Shared iterations

Screenshot 2024-07-09 at 16 08 31

Ramping VUs

Screenshot 2024-07-09 at 16 08 47

2Steaks added 2 commits July 5, 2024 17:08
@2Steaks
Initial commit
e4e31c8
@2Steaks
feat: Add Load Profile options
a2251d3 
- Add DurationInput component
- Update GenerationDrawer for scrolling
@2Steaks 2Steaks self-assigned this Jul 9, 2024
Llandy3d
Llandy3d approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the functionality standpoint looks great! 🙌

going-confetti
going-confetti approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@going-confetti going-confetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2Steaks added 2 commits July 10, 2024 10:09
@2Steaks
refactor: Update load profile state
2fad081
@2Steaks
Merge branch 'main' into feat/load-profile-options-component
ebbb2fc 
# Conflicts:
#	.nvmrc
#	src/views/Generator/GeneratorDrawer/GeneratorDrawer.tsx
e-fisher
e-fisher approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@2Steaks 2Steaks merged commit 148a9c9 into main Jul 10, 2024
1 check passed
@2Steaks 2Steaks deleted the feat/load-profile-options-component branch July 10, 2024 15:29
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Closed
@croco-bot croco-bot mentioned this pull request Jan 24, 2025
Merged
@croco-bot croco-bot mentioned this pull request Feb 13, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@going-confetti going-confetti going-confetti approved these changes

@e-fisher e-fisher e-fisher approved these changes

@Llandy3d Llandy3d Llandy3d approved these changes

Assignees

@2Steaks 2Steaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2Steaks @going-confetti @e-fisher @Llandy3d