feat: enable usage report #270
Conversation
cristianoventura
requested review from
going-confetti and
Llandy3d
and removed request for
a team
src/usageReport.ts
Outdated
| @@ -0,0 +1,55 @@ | |||
| import { v4 as uuidv4 } from 'uuid' | |||
There was a problem hiding this comment.
We use self.crypto.randomUUID in others places in k6 studio, I don't think a separate module is needed
There was a problem hiding this comment.
That's on me!
I didn't notice :)
| Please send my anonymous usage data to Grafana to aid in | ||
| development of k6 Studio.{' '} |
There was a problem hiding this comment.
I'd avoid using "please" (as mentioned in Grafana's UX writing guide)
| <Text size="2" as="label"> | ||
| <Checkbox | ||
| {...register('usageReport.enabled')} | ||
| defaultChecked |
There was a problem hiding this comment.
IMO this is redundant: the field should reflect the current settings: if they are saved in the file, the user will see the value from the file; if not, the user will see the default value
src/usageReport.ts
Outdated
| }, | ||
| }) | ||
| } catch (e) { | ||
| console.log('Error sending report', e) |
There was a problem hiding this comment.
Since we don't send the report when running the app in dev env, this line isn't really needed. I think we should either log it in the app logs, or fail silently instead
There was a problem hiding this comment.
I think fail silently in this case is more appropriate, error from this would just be noise 🤔
Description
This PR introduces changes to collect usage report data when running a k6 script as well as the following when running k6 Studio:
The user can opt-out of the usage report by disabling it in the Settings dialog.
How to Test
usageReport.enabledproperty is properly saved--no-usage-reportis passed to the k6 binary (you can do that by logging thek6Argsarray in thescript.tsfile.Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)