Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify dialog style between test options and allowed hosts #286

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

e-fisher
Copy link
Collaborator

Description

Use popover style dialog for allow list to match the style of test options. It also removes "save" and "discard" buttons from the allow list dialog to match other forms. The changes are reflected immediately without closing dialog.

How to Test

  • Verify dialog is automatically opened for new recordings
  • Verify dialog is opened when switching to recording with additional hosts or different hosts
  • Try to add/remove hosts, switch static assets

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

CleanShot 2024-10-29 at 15 28 21

CleanShot 2024-10-29 at 15 28 25

Related PR(s)/Issue(s)

@e-fisher e-fisher requested a review from a team as a code owner October 29, 2024 13:34
@e-fisher e-fisher requested review from going-confetti and cristianoventura and removed request for a team October 29, 2024 13:34
Copy link
Collaborator

@going-confetti going-confetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@cristianoventura cristianoventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@e-fisher e-fisher merged commit 440d032 into main Oct 29, 2024
2 checks passed
@e-fisher e-fisher deleted the fix/match-allowed-hosts-modal-to-options branch October 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants