fix: Show loading indicator while browser is starting when recording #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
requested review from
going-confetti and
cristianoventura
and removed request for
a team
e-fisher
deleted the
fix/show-message-while-browser-is-loading-in-recorder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we would show empty screen while recorder is starting and we haven't received any requests yet. It also didn't allow changing group name after clearing requests. This PR adds "Requests will appear here" loading indicator and fixes group rename issue.
Before:
CleanShot.2024-10-30.at.13.06.00.mp4
After:
CleanShot.2024-10-30.at.13.06.30.mp4
How to Test
Verify loading state and empty state is displayed as expected in recorder, recorded har viewer and validator.
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)