feat: Add allowlist #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
commented
Jul 15, 2024
| @@ -501,7 +501,7 @@ const extractCorrelationJsonBody = ( | |||
| } | |||
|
|
|||
| const extractedValue = get( | |||
| JSON.parse(response.content), | |||
| safeJsonParse(response.content), | |||
There was a problem hiding this comment.
This was failing on some recording
going-confetti
approved these changes
Jul 15, 2024
| > | ||
| Allowed hosts [{allowList.length}/{hosts.length}] | ||
| </Button> | ||
| {/* Radix does not unmount dialog on close, this is need to clear local state */} |
There was a problem hiding this comment.
In future, we can create our own wrappers for components we use often to simplify the API (for example, for dropdown menus/selects) and change the behavior like in this case 🤔
Comment on lines
94
to
103
| <CheckboxGroup.Root | ||
| value={selectedHosts} | ||
| onValueChange={(e) => setSelectedHosts(e)} | ||
| > | ||
| {filteredHosts.map((host) => ( | ||
| <CheckboxGroup.Item value={host} key={host}> | ||
| {host} | ||
| </CheckboxGroup.Item> | ||
| ))} | ||
| </CheckboxGroup.Root> |
There was a problem hiding this comment.
Should probably have max-height + scroll
There was a problem hiding this comment.
Added! I didn't go with maxHeight, but used height instead to avoid dialog resizing when searching:
|
Moved allowlist to heading:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/grafana/k6-cloud/issues/2508