feat: Theme switcher #32
Merged
+317
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
commented
Jul 15, 2024
| :root { | ||
| /* Allotment */ | ||
| --focus-border: var(--violet-9); | ||
| --separator-border: var(--gray-4); |
There was a problem hiding this comment.
shades of gray didn't work in index.css and don't work here, if I had to guess, the radix color "context" is not available at this stage (for example, --violet-9 works, but --accent-9 doesn't) 🤔
| > | ||
| <Drawer close={leftDrawer.close}>{leftDrawer.content}</Drawer> | ||
| </Allotment.Pane> | ||
| {leftDrawer.isOpen && ( |
There was a problem hiding this comment.
There was a visible border between the main section and the left drawer even when the drawer wasn't visible
e-fisher
approved these changes
Jul 15, 2024
| console.log('theme', theme) | ||
|
|
||
| const handleClick = () => { | ||
| window.studio.settings.toggleTheme() |
There was a problem hiding this comment.
Possible future improvement: remember user's preferred theme when reopening app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.