feat: load generator file #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e82b4bb.
Llandy3d
commented
Jul 19, 2024
| generatorFileData.allowlist.includes(request.request.host) | ||
| ) | ||
| // TODO: is this really required to be set ? | ||
| generatorState.setFilteredRequests(filteredRequests) |
There was a problem hiding this comment.
this is not update the UI, so the allowedlist is not updated and no request is shown
There was a problem hiding this comment.
This shouldn't be a problem with the latest main
going-confetti
approved these changes
Jul 19, 2024
| generatorFileData.allowlist.includes(request.request.host) | ||
| ) | ||
| // TODO: is this really required to be set ? | ||
| generatorState.setFilteredRequests(filteredRequests) |
There was a problem hiding this comment.
This shouldn't be a problem with the latest main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the state from the loaded generator file.
Then
har:openevent now accepts an optional file path to specify which file to open or show a dialog if no file is specified.