Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal(Thresholds): polish UI #464

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Conversation

cristianoventura
Copy link
Collaborator

Description

This PR addresses some UI inconsistencies and bugs on the Thresholds feature.

  • Tooltip in the URLs Select component
  • Rename "Stop" column to "Stop test"
  • Fix isRunning state in Validator Dialog when a threshold crosses
  • Remember last selected tab in Test Options

How to Test

  • Enable the Thresholds feature
  • Check the Thresholds tab in Test Options

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

image

Related PR(s)/Issue(s)

@cristianoventura cristianoventura requested a review from a team as a code owner February 10, 2025 19:04
@cristianoventura cristianoventura changed the title Internal(Thresholds): polish UI internal(Thresholds): polish UI Feb 10, 2025
going-confetti
going-confetti previously approved these changes Feb 11, 2025
@cristianoventura cristianoventura merged commit f20710c into main Feb 11, 2025
3 checks passed
@cristianoventura cristianoventura deleted the internal/polish-thresholds-ui branch February 11, 2025 19:04
@cristianoventura cristianoventura self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants