feat: Start new recording from Sidebar #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Llandy3d
approved these changes
Aug 5, 2024
going-confetti
commented
Aug 6, 2024
src/AppRoutes.tsx
Outdated
| @@ -42,6 +47,7 @@ export function AppRoutes() { | |||
| </Route> | |||
| </Route> | |||
| <Route path={routeMap.validator} element={<Validator />} /> | |||
| <Route path="*" element={<Navigate to={routeMap.home} replace />} /> | |||
There was a problem hiding this comment.
Sometimes during development you end up with a wrong route (this shouldn't happen in production, but we may want to show an alert notification in such cases). Previously, you'd have to manually reset the location (window.location.replace('/')), this adds a 404 route that just redirects to the home view
going-confetti
commented
Aug 6, 2024
| @@ -50,7 +50,7 @@ export function Recorder() { | |||
| ) | |||
|
|
|||
| navigate( | |||
| `${getRoutePath('recordingPreviewer', { path: filePath })}}?discardable` | |||
e-fisher
reviewed
Aug 6, 2024
Should be fixed now 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.