Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace url and path for url regex matchers #287

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: replace url and path for url regex matchers #287

merged 2 commits into from
Oct 30, 2024

Conversation

e-fisher
Copy link
Collaborator

Description

Show replaced path in parameterization preview

Before:

CleanShot 2024-10-30 at 10 55 35

After:

CleanShot 2024-10-30 at 10 54 54

How to Test

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

Related PR(s)/Issue(s)

@e-fisher e-fisher requested a review from a team as a code owner October 30, 2024 08:57
@e-fisher e-fisher requested review from going-confetti and cristianoventura and removed request for a team October 30, 2024 08:57
Llandy3d
Llandy3d previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
Should it maybe say "requests replaced" ? 🤔

@e-fisher e-fisher requested a review from Llandy3d October 30, 2024 11:14
@e-fisher e-fisher merged commit 4de35ea into main Oct 30, 2024
2 checks passed
@e-fisher e-fisher deleted the fix/parameterization-path-preview branch October 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Llandy3d Llandy3d Llandy3d approved these changes

@going-confetti going-confetti Awaiting requested review from going-confetti going-confetti is a code owner automatically assigned from grafana/k6-studio

@cristianoventura cristianoventura Awaiting requested review from cristianoventura cristianoventura is a code owner automatically assigned from grafana/k6-studio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-fisher @Llandy3d