Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor ui bugs #295

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: Minor ui bugs #295

merged 3 commits into from
Oct 31, 2024

Conversation

e-fisher
Copy link
Collaborator

Description

  1. When there's a script error, the generator sidebar tabs can get covered

CleanShot 2024-10-31 at 15 12 38

  1. Add padding to home screen

CleanShot 2024-10-31 at 14 58 17

How to Test

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

Related PR(s)/Issue(s)

@e-fisher e-fisher requested a review from a team as a code owner October 31, 2024 14:07
@e-fisher e-fisher requested review from going-confetti and cristianoventura and removed request for a team October 31, 2024 14:07
Llandy3d
Llandy3d approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Llandy3d Llandy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@e-fisher e-fisher merged commit 8395532 into main Oct 31, 2024
2 checks passed
@e-fisher e-fisher deleted the fix/ui-bugs branch October 31, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Llandy3d Llandy3d Llandy3d approved these changes

@cristianoventura cristianoventura cristianoventura approved these changes

@going-confetti going-confetti Awaiting requested review from going-confetti going-confetti is a code owner automatically assigned from grafana/k6-studio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-fisher @cristianoventura @Llandy3d