Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hostname as prefix of har filename #362

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

cristianoventura
Copy link
Collaborator

Description

This PR provides a more meaningful file name for the recording based on the starting URL.

How to Test

  • start a new recording
  • input the starting URL
  • stop the recording
  • check that the generated HAR file contains hostname of the starting URL
  • check that omitting the starting URL does not include any prefix

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

image

Related PR(s)/Issue(s)

Resolves #306

@cristianoventura cristianoventura self-assigned this Nov 22, 2024
@cristianoventura cristianoventura requested a review from a team as a code owner November 22, 2024 16:25
@cristianoventura cristianoventura requested review from going-confetti and e-fisher and removed request for a team November 22, 2024 16:25
Copy link
Collaborator

@going-confetti going-confetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@cristianoventura cristianoventura merged commit 3c5bec3 into main Nov 22, 2024
2 checks passed
@cristianoventura cristianoventura deleted the feat/hostname-in-recording-filename branch November 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a meaningful HAR file name
2 participants