feat: Highlight search matches #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
force-pushed
the
feat/higlight-search-matches
branch
from
84fe087 to
b2aa347
Compare
e-fisher
commented
Nov 28, 2024
| onUpdateGroup?: (group: GroupType) => void | ||
| } | ||
|
|
||
| export function WebLogView({ | ||
| // Memo improves performance when filtering | ||
| export const WebLogView = memo(function WebLogView({ |
There was a problem hiding this comment.
Added memo improves performance when filtering large recordings - avoid re-rendering on every keystroke, and allows debounce inside useFilterRequests to kick in.
e-fisher
requested review from
cristianoventura and
Llandy3d
and removed request for
a team
|
I was testing it out and noticed this match, is it supposed to match that first entry ? 🤔 
|
Yeah, that's the "fuzziness", perhaps we don't need it to be this loose in this context, I'll lower the threshold |
cristianoventura
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Highlight matched values when searching requests. Thank @allansson for laying the groundwork and extracting reusable highlight component! 🙌 I've tweaked the colors a bit to make it easier to see the highlighted parts.
How to Test
Test search in recorder, generator, and validator - verify matches are highlighted.
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #322