feat: add type column to WebLogView #372
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoventura
requested review from
going-confetti and
e-fisher
and removed request for
a team
src/components/WebLogView/Row.tsx
Outdated
| @@ -53,6 +54,11 @@ export function Row({ data, isSelected, onSelectRequest }: RowProps) { | |||
| /> | |||
| </ResponseStatusBadge> | |||
| </Table.Cell> | |||
| <Table.Cell> | |||
| <Text size="1"> | |||
| {isNonStaticAssetResponse(data) ? 'Dynamic' : 'Static'} | |||
There was a problem hiding this comment.
I was under the impression we wanted this to work similarly to the browser dev tools:
If we only want to mark static requests, I suggest something that will take less horizontal space in WebLogView - maybe an icon or something like that
cristianoventura
commented
Dec 6, 2024
There was a problem hiding this comment.
@going-confetti I made a change to include a more descriptive "type" based on the content-type returned by the request.
|
|
||
| export function getRequestType(data: ProxyData) { | ||
| if (isNonStaticAssetResponse(data)) { | ||
| return 'fetch' |
There was a problem hiding this comment.
ChromeDevTools categorizes this a bit more. I was debating whether to call it "document", "dynamic" or "fetch". Any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
Typecolumn to theWebLogViewcomponent to differentiate static assets from dynamic requests.How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #325