Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to disable a rule #375

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat: ability to disable a rule #375

merged 3 commits into from
Dec 10, 2024

Conversation

cristianoventura
Copy link
Collaborator

Description

This PR introduces the ability to disable/enable a test rule. Disable rules will not be generated by the script.

How to Test

  • Create a new Test Rule
  • Disable the rule and check that it was not generated by the script
  • Re-enable the same rule and check that it is now generated by the script

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

image

Related PR(s)/Issue(s)

Resolves #313

@cristianoventura cristianoventura self-assigned this Dec 5, 2024
@cristianoventura cristianoventura requested a review from a team as a code owner December 5, 2024 18:46
@cristianoventura cristianoventura requested review from e-fisher and Llandy3d and removed request for a team December 5, 2024 18:46
Copy link
Collaborator

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! 🙌

The verification rule doesn't have a status label, but I was thinking - maybe instead of added a label we could drop opacity to 0.5 and add hover tooltip "disabled" when rule is not enabled.
The reasoning behind this: in most cases all my rules will be enabled and seeing "enabled" label repeated just adds noise. Here's how it could look like:

Screenshot 2024-12-06 at 14 49 02

@cristianoventura
Copy link
Collaborator Author

cristianoventura commented Dec 9, 2024

Works as advertised! 🙌

The verification rule doesn't have a status label, but I was thinking - maybe instead of added a label we could drop opacity to 0.5 and add hover tooltip "disabled" when rule is not enabled. The reasoning behind this: in most cases all my rules will be enabled and seeing "enabled" label repeated just adds noise. Here's how it could look like:

I like the idea of reducing noise! I've made the changes you suggested @e-fisher
We already have tooltips inside the row and, adding an outer tooltip works but it loses the focus when the inner tooltip is activated. Overall I think it's still useful to have it!

Copy link
Collaborator

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cristianoventura cristianoventura merged commit 564aab9 into main Dec 10, 2024
2 checks passed
@cristianoventura cristianoventura deleted the feat/disable-rule branch December 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to disable a Rule
2 participants