From 21d369e6b6e279caa3eee4293beab943cf6f85a3 Mon Sep 17 00:00:00 2001 From: Oleg Bespalov Date: Mon, 15 Jul 2024 17:25:19 +0200 Subject: [PATCH] Simplify the test for gRPC streams metrics tags --- js/modules/k6/grpc/stream_test.go | 28 ++++------------------------ 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/js/modules/k6/grpc/stream_test.go b/js/modules/k6/grpc/stream_test.go index 25b8876f899..16a07ba557b 100644 --- a/js/modules/k6/grpc/stream_test.go +++ b/js/modules/k6/grpc/stream_test.go @@ -417,34 +417,14 @@ func TestStream_MetricsTagsMetadata(t *testing.T) { stub := &featureExplorerStub{} - savedFeatures := []*grpcservice.Feature{ - { + stub.listFeatures = func(_ *grpcservice.Rectangle, stream grpcservice.FeatureExplorer_ListFeaturesServer) error { + return stream.Send(&grpcservice.Feature{ Name: "foo", Location: &grpcservice.Point{ Latitude: 1, Longitude: 2, }, - }, - { - Name: "bar", - Location: &grpcservice.Point{ - Latitude: 3, - Longitude: 4, - }, - }, - } - - stub.listFeatures = func(_ *grpcservice.Rectangle, stream grpcservice.FeatureExplorer_ListFeaturesServer) error { - for _, feature := range savedFeatures { - // adding a delay to make server response "slower" - time.Sleep(200 * time.Millisecond) - - if err := stream.Send(feature); err != nil { - return err - } - } - - return nil + }) } grpcservice.RegisterFeatureExplorerServer(ts.httpBin.ServerGRPC, stub) @@ -497,7 +477,7 @@ func TestStream_MetricsTagsMetadata(t *testing.T) { samplesBuf := metrics.GetBufferedSamples(ts.samples) - assert.Len(t, samplesBuf, 5) + assert.Len(t, samplesBuf, 4) for _, samples := range samplesBuf { for _, sample := range samples.GetSamples() { assertTags(t, sample, expTags)