Memory leak in the cloud output #1187
Comments
cuonglm
added a commit
that referenced
this issue
Oct 7, 2019
In #1130, we stop sending metrics to cloud when limit reached. However, after stop sending metrics, collector still collects data, causing the memory usage quickly increase. To fix it, do not collect data if stop sending metrics triggered. While at it, also remove some useless condition checking that slice length is greater than 0 before looping. Fixes #1187
cuonglm
added a commit
that referenced
this issue
Oct 7, 2019
* fix memory leak after stop sending metrics to cloud In #1130, we stop sending metrics to cloud when limit reached. However, after stop sending metrics, collector still collects data, causing the memory usage quickly increase. To fix it, do not collect data if stop sending metrics triggered. While at it, also remove some useless condition checking that slice length is greater than 0 before looping. Fixes #1187
cuonglm
added a commit
that referenced
this issue
Oct 15, 2019
* fix memory leak after stop sending metrics to cloud In #1130, we stop sending metrics to cloud when limit reached. However, after stop sending metrics, collector still collects data, causing the memory usage quickly increase. To fix it, do not collect data if stop sending metrics triggered. While at it, also remove some useless condition checking that slice length is greater than 0 before looping. Fixes #1187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#1130 caused a regression - when the Load Impact cloud sends this the limit reached error, k6 would stop sending metrics to the cloud, but it would still continue to accept them in
Collect()and store them in the buffer slices, thus rapidly exploding the memory usage.The text was updated successfully, but these errors were encountered: