Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gRPC connection state management #1808

Closed
na-- opened this issue Jan 19, 2021 · 1 comment
Closed

Improve gRPC connection state management #1808

na-- opened this issue Jan 19, 2021 · 1 comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature

Comments

@na--
Copy link
Member

na-- commented Jan 19, 2021

https://community.k6.io/t/reconnect-in-grpc/1286 is a good example of how our gRPC implementation is not very flexible yet. Specifically, we don't have a good way to detect client disconnects. And I don't have a good idea how to handle them well, though something event-based seems reasonable, so we might need to implement #882 before we can...

@na-- na-- added feature evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Jan 19, 2021
@codebien
Copy link
Contributor

codebien commented Apr 8, 2024

I'm closing as this issue seems unlikely to be resolved.
If the client disconnects then I expect a re-run of the test will be required. The cases where the user wants to test the client disconnecting sound minor. And, in any case, with a bit of effort, the goal is still achievable by using the StatusDeadlineExceeded code as proved on the forum.

The current logic using the status code as proposed on the forum seems enough. We may re-evaluate the decision in the future if we find a higher demand.

@codebien codebien closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature
Projects
None yet
Development

No branches or pull requests

2 participants