Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test support of the canonical Protobuf JSON Mapping #3569

Open
olegbespalov opened this issue Jan 26, 2024 · 0 comments
Open

Test support of the canonical Protobuf JSON Mapping #3569

olegbespalov opened this issue Jan 26, 2024 · 0 comments
Labels
area: grpc docs documentation-needed A PR which will need a separate PR for documentation tests

Comments

@olegbespalov
Copy link
Contributor

olegbespalov commented Jan 26, 2024

What?

In our documentation, we say that we do support canonical Protobuf JSON Mapping.

And this is probably the case since we use the protojson.

But it's good to validate it by creating a dedicated test case (we do test some of the mappings partially in client_test.go) where we test all mappings.

If we don't support something from the canonical mapping, it's good to document it somewhere on the gRPC protocol's page at https://grafana.com/docs/k6/latest/using-k6/protocols/grpc/

Related PRs / issues

Why?

Mapping JSON (from k6's scripts) to Protobuf should be well-tested and documented.

@olegbespalov olegbespalov added docs tests documentation-needed A PR which will need a separate PR for documentation area: grpc labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: grpc docs documentation-needed A PR which will need a separate PR for documentation tests
Projects
None yet
Development

No branches or pull requests

1 participant