Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests due to api address collisions #3846

Open
mstoykov opened this issue Jul 15, 2024 · 0 comments
Open

Flaky tests due to api address collisions #3846

mstoykov opened this issue Jul 15, 2024 · 0 comments
Labels

Comments

@mstoykov
Copy link
Collaborator

image

This seems to happen because

func getFreeBindAddr(tb testing.TB) string {

is used to get the address, but it gets an address, then closes it. And after that k6 uses it.

There is a not small chance that another test will ask for an address between the close and k6 using it and then it will not be free. In practice even another process on the OS can get that address.

Unfortunately quite a lot of tests do use the address, so we can't just remove it.

It might be nice if we can get it from k6 running (maybe logs) and then use it to communicate?
Maybe we should not set it for tests that don't need it?

@mstoykov mstoykov added the tests label Jul 15, 2024
@codebien codebien changed the title Flakt tests due to api address collisions Flaky tests due to api address collisions Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant