Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew forumlar for k6 version v0.39.0 #3950

Closed
wants to merge 1 commit into from

Conversation

cheuk0324
Copy link

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@cheuk0324 cheuk0324 requested a review from a team as a code owner September 12, 2024 20:33
@cheuk0324 cheuk0324 requested review from mstoykov and joanlopez and removed request for a team September 12, 2024 20:33
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cheuk0324 cheuk0324 closed this Sep 12, 2024
@cheuk0324 cheuk0324 deleted the 0.39.0 branch September 12, 2024 20:34
@mstoykov
Copy link
Contributor

I understand that this was unintentionally opened PR, but I would just like to ask why you are trying to get v0.39.0 which at this point is over 2 years old?

Thank you for your time @cheuk0324 🙇

@cheuk0324
Copy link
Author

@mstoykov Apology for the Inconvenience. So we have tests thats only run with older version of the k6 but for some of the new engineers, they are not able to install the older through brew, because the k6 from homebrew is always the latest. So we tried to created the tap with the tag version.

I hope there is an easier way that we can install older version of k6 from homebrew. Or is there better way to do that? Thanks!

@mstoykov
Copy link
Contributor

I hope there is an easier way that we can install older version of k6 from homebrew. Or is there better way to do that? Thanks!

I've never used Mac personally and for that matter homebrew - so no idea.

You can get te binary directly from the release page at the bottom.

So we have tests thats only run with older version of the k6

Can you share what in particular as it seems strange as v0.40.0 didn't really have breaking changes that seem all that impactful. So it seems strange to me that instead of updating scripts you will try to keep to and old version. And in this case an over 2 year old verison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants