Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handleSummary func timeout configurable #3977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-kattathra-johnson
Copy link

@alex-kattathra-johnson alex-kattathra-johnson commented Oct 3, 2024

What?

It makes the timeout for the handleSummary function configurable

Why?

To solve issue #3976. To allow for generating summary for long running tests

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3976

@alex-kattathra-johnson alex-kattathra-johnson requested a review from a team as a code owner October 3, 2024 03:28
@alex-kattathra-johnson alex-kattathra-johnson requested review from mstoykov and olegbespalov and removed request for a team October 3, 2024 03:28
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>
@taylorflatt
Copy link

I'd make sure to update the docs as well if this change does move forward: https://grafana.com/docs/k6/latest/using-k6/k6-options/reference/

See: https://github.com/grafana/k6-docs

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🙇

It seems to me like you are changing way too many tests and I expect there might be some problems with the propagation of the default.

Can you try to rever each of the test changes and see if you can reduce them? I haven't commented in each place.

It also will be nice to get a test case in https://github.com/grafana/k6/blob/master/cmd/config_consolidation_test.go#L146 as that is where consolidation is usually tested as well as defaults.

Comment on lines +58 to +61
exports.options = {
summaryTrendStats: %s,
handleSummaryTimeout: '120s',
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to update all of those tests ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the defaults are set at the cmd level. But, these unit tests are testing the functionality of these respective modules independent of the runtime defaults.

@mstoykov mstoykov added enhancement documentation-needed A PR which will need a separate PR for documentation labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-needed A PR which will need a separate PR for documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to configure the 120 second timeout when generating end of test statistics
4 participants