Move opentelemetry's ouput code to the k6 core #4562

olegbespalov · 2025-02-19T12:43:38Z

What?

Moving the code of the opentelemetry output to the k6 core.

https://github.com/grafana/xk6-output-opentelemetry is going to be archived.

Why?

This should simplify it maintenance

Checklist

I have performed a self-review of my code.
I have added tests for my changes.
I have run linter locally (make lint) and all checks pass.
I have run tests locally (make tests) and all tests pass.
I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Creates basic docker-compose that could be used for the local running/testing opentelemetry output. It contains Grafana, Grafana Alloy (which has OTEL receivers) and Prometheus as metric backend.

It has limited support of metric types (count, gauge, trend(?)). Only gRPC receiver. Limited configuration.

Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>

Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>

Downgrade gopkg.in/guregu/null.v3 to reflect k6

Allow service.name otel env variable

test(output): add integration tests

…64d41cd08036581008183' git-subtree-dir: internal/output/opentelemetry git-subtree-mainline: cfe4715 git-subtree-split: dc79ff2

CLAassistant · 2025-02-19T12:43:51Z

All committers have signed the CLA.

inancgumus

We just moved OT's output code to the k6 core, right? What should I look out for in this PR?

olegbespalov · 2025-02-19T16:11:33Z

We just moved OT's output code to the k6 core, right? What should I look out for in this PR?

@inancgumus well, technically yes + perform clean up, but still, we follow our formal process, and it required to get 2 approvals to merge the PR 😅

olegbespalov · 2025-02-19T16:13:39Z

But currently it's blocked to merge anyway because it indicates that we're missing the CLA sign from @TimotejKovacka which was actually performed in

TimotejKovacka · 2025-02-19T17:01:19Z

Sorry to keep you guys blocked, as soon as I saw the notification I went and signed the agreement although I'm pretty sure I had done this in the past too, not sure how this became an issue now.

olegbespalov · 2025-02-19T17:12:33Z

Hey @TimotejKovacka

No, I didn't mean that you blocked this PR, we were still trying to figure out why that happened on our/CLA side, I mean we know that you've already signed CLA 👍

But let me use this again as the opportunity to say thank you for your contributions 🙇 🙌

go.mod

codebien

🎉

olegbespalov and others added 30 commits May 15, 2024 08:03

Initial commit

c9c5434

Skeleton structure from xk6 output template

1a487f3

Basic CI

46403a9

Adds CODEOWNERS

ae7671c

Using common Makefile

ddebd1a

chore: go mod tidy

42d054b

Ignores local golangcilint config

9f69fd4

Base OTEL docker-compose

9fb92af

Creates basic docker-compose that could be used for the local running/testing opentelemetry output. It contains Grafana, Grafana Alloy (which has OTEL receivers) and Prometheus as metric backend.

Minimal working version

8ddf863

It has limited support of metric types (count, gauge, trend(?)). Only gRPC receiver. Limited configuration.

Align config options with OTEL, HTTP exporter

7083c18

Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>

Update k6's version

6370428

Refactor to metrics registry

de62ccc

Implement Rate splitting

52d135a

Apply suggestions from code review Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>

Adjust dashboard

02e1c0d

A proper gauge

d0f4424

Fix demo dashboard

8e51082

Rename template leftovers

8585004

Config consolidation

1e26470

More test cases

f2a93ed

Wrap validation error with the right exit code

edd1a97

Remove obsolete

b297321

Set default export interval as 10s

4499201

Passing metrics unit when available

2ff1f89

TLS configuration

4cdf100

Headers configuration

62ac853

Downgrade gopkg.in/guregu/null.v3 to reflect k6

da075ca

Merge pull request #17 from grafana/chore/downgrade-dependency

8049cf9

Downgrade gopkg.in/guregu/null.v3 to reflect k6

Downgrade afero to a version that frozen in k6 core

6a542f1

Downgrade opentelemetry to reflect k6 core

411cf08

Bump k6 to v0.52

7a50ee7

TimotejKovacka and others added 6 commits September 29, 2024 13:38

Allow service.name otel env variable

1b97bf3

Merge pull request #24 from TimotejKovacka/main

133ea7f

Allow service.name otel env variable

test(output): add integration tests

14cfd08

Merge pull request #26 from TimotejKovacka/main

dc79ff2

test(output): add integration tests

Add 'internal/output/opentelemetry/' from commit 'dc79ff2430d29f77699…

de3082c

…64d41cd08036581008183' git-subtree-dir: internal/output/opentelemetry git-subtree-mainline: cfe4715 git-subtree-split: dc79ff2

output opentelemetry: cleanup unnsecessary files

6f7f6b0

olegbespalov self-assigned this Feb 19, 2025

olegbespalov requested a review from a team as a code owner February 19, 2025 12:43

olegbespalov requested review from mstoykov and inancgumus and removed request for a team February 19, 2025 12:43

olegbespalov added this to the v1.0.0-rc1 milestone Feb 19, 2025

joanlopez changed the title ~~Move opentelemetry's ouput code to the k6 coree~~ Move opentelemetry's ouput code to the k6 core Feb 19, 2025

inancgumus reviewed Feb 19, 2025

View reviewed changes

inancgumus previously approved these changes Feb 19, 2025

View reviewed changes

codebien reviewed Feb 20, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

output opentelemetry: move to using the in k6 code

72b7884

olegbespalov dismissed inancgumus’s stale review via 72b7884 February 20, 2025 09:23

olegbespalov force-pushed the feat/opentelemetry-output branch from 57fc6cb to 72b7884 Compare February 20, 2025 09:23

codebien approved these changes Feb 20, 2025

View reviewed changes

oleiade approved these changes Feb 20, 2025

View reviewed changes

joanlopez approved these changes Feb 20, 2025

View reviewed changes

olegbespalov merged commit 1017671 into master Feb 20, 2025
28 checks passed

olegbespalov deleted the feat/opentelemetry-output branch February 20, 2025 10:37

olegbespalov mentioned this pull request Feb 20, 2025

Warning that repository in no longer maintained grafana/xk6-output-opentelemetry#28

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move opentelemetry's ouput code to the k6 core #4562

Move opentelemetry's ouput code to the k6 core #4562

olegbespalov commented Feb 19, 2025 •

edited

Loading

CLAassistant commented Feb 19, 2025 •

edited

Loading

inancgumus left a comment

olegbespalov commented Feb 19, 2025

olegbespalov commented Feb 19, 2025

TimotejKovacka commented Feb 19, 2025

olegbespalov commented Feb 19, 2025

codebien left a comment

Move opentelemetry's ouput code to the k6 core #4562

Move opentelemetry's ouput code to the k6 core #4562

Conversation

olegbespalov commented Feb 19, 2025 • edited Loading

What?

Why?

Checklist

Related PR(s)/Issue(s)

CLAassistant commented Feb 19, 2025 • edited Loading

inancgumus left a comment

Choose a reason for hiding this comment

olegbespalov commented Feb 19, 2025

olegbespalov commented Feb 19, 2025

TimotejKovacka commented Feb 19, 2025

olegbespalov commented Feb 19, 2025

codebien left a comment

Choose a reason for hiding this comment

olegbespalov commented Feb 19, 2025 •

edited

Loading

CLAassistant commented Feb 19, 2025 •

edited

Loading