Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor collector registration #917

Closed
mstoykov opened this issue Feb 1, 2019 · 1 comment · Fixed by #1869
Closed

Refactor collector registration #917

mstoykov opened this issue Feb 1, 2019 · 1 comment · Fixed by #1869
Assignees
@na--
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor
Milestone
v0.31.0

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Feb 1, 2019

Currently every adding of collector means that we need to touch https://github.com/loadimpact/k6/blob/9af59bc1ca2eee2f065a544c9400c08875c5d268/cmd/collectors.go#L58-L99 . This should probably be instead be done in the same way the standard sql package works.
@mstoykov mstoykov mentioned this issue Feb 1, 2019
Merged
@na-- na-- mentioned this issue Jul 9, 2019
Closed
@na-- na-- added evaluation needed proposal needs to be validated or tested before fully implementing it in k6 and removed good first issue labels Sep 8, 2020
@na--
Copy link
Member

na-- commented Nov 26, 2020

This is important, since it's probably the main issue preventing us from offering output plugins, now that xk6 is a thing.

@na-- na-- self-assigned this Jan 26, 2021
@na-- na-- added this to the v0.31.0 milestone Jan 27, 2021
@na-- na-- mentioned this issue Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@na-- na--

Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

Output refactoring grafana/k6
2 participants
@mstoykov @na--