Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor http.Response to have httpext.Response embeded #946

Closed
mstoykov opened this issue Mar 11, 2019 · 2 comments
Closed

Refactor http.Response to have httpext.Response embeded #946

mstoykov opened this issue Mar 11, 2019 · 2 comments
Labels
good first issue lower prio performance refactor

Comments

@mstoykov
Copy link
Contributor

After #907 and dop251/goja@64be363 we can get httpext.Response to be an anonymous struct in http.Response as this will also give us back the ability to cache the whole json as a goja object
@mstoykov mstoykov mentioned this issue Mar 11, 2019
Merged
@mstoykov mstoykov mentioned this issue Feb 9, 2021
Merged
@namit-chandwani
Copy link

Hey @mstoykov, I'd like to work on this issue.
What would be a good starting point for resolving this?

@mstoykov
Copy link
Contributor Author

mstoykov commented Oct 4, 2021

hi @namit-chandwani , kind of unfortunately I think this was fixed by #1259 and #1841 but wasn't closed :(.

@mstoykov mstoykov closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue lower prio performance refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstoykov @namit-chandwani