Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the path to the error when trying to open() a directory #1238

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 12, 2019

closes #1234

proposed release notes in "Bugfixes"(we should have "small changes or miscellaneous"):

JS: add the path to the error message when `open()` is used with a directory (#1238)

@mstoykov mstoykov added this to the v0.26.0 milestone Nov 12, 2019
@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #1238 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files         148      148           
  Lines       10763    10763           
=======================================
  Hits         8109     8109           
  Misses       2189     2189           
  Partials      465      465
Impacted Files Coverage Δ
js/initcontext.go 90.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d6dd4...54d61d6. Read the comment docs.

cuonglm
cuonglm previously approved these changes Nov 12, 2019
na--
na-- previously approved these changes Nov 13, 2019
@mstoykov mstoykov dismissed stale reviews from na-- and cuonglm via 99ef036 November 13, 2019 07:04
cuonglm
cuonglm previously approved these changes Nov 13, 2019
imiric
imiric previously approved these changes Nov 13, 2019
@mstoykov mstoykov merged commit 207cad7 into master Nov 13, 2019
@mstoykov mstoykov deleted the fixOpenDirectoryMessage branch March 30, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERRO[0001] GoError: open() can't be used with directories
5 participants