Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the cloud output to the new Output interface #1874

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

na--
Copy link
Member

@na-- na-- commented Mar 1, 2021

Follow up to #1869 and #1870. Closes #1258 and moves the cloud output to the new Output interface.

@na-- na-- requested review from mstoykov and imiric March 1, 2021 12:25
@na-- na-- added this to the v0.31.0 milestone Mar 1, 2021
@na-- na-- force-pushed the move-cloud-output-to-new-interface branch from 005ebac to 0efcf86 Compare March 2, 2021 15:20
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cloudapi/util.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually just checked 2 or 3 things I wasn't sure about with the config and a thing that definitely doesn't work is picking up my subscription from the config file

@na-- na-- force-pushed the move-cloud-output-to-new-interface branch from 0efcf86 to a67b3a1 Compare March 4, 2021 11:51
@na-- na-- force-pushed the move-cloud-output-to-new-interface branch from a67b3a1 to 7d50a9e Compare March 4, 2021 11:52
@na-- na-- requested a review from mstoykov March 4, 2021 11:53
@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #1874 (2ef51b5) into master (a44f5dc) will increase coverage by 0.13%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
+ Coverage   71.03%   71.16%   +0.13%     
==========================================
  Files         183      183              
  Lines       14316    14306      -10     
==========================================
+ Hits        10169    10181      +12     
+ Misses       3530     3497      -33     
- Partials      617      628      +11     
Flag Coverage Δ
ubuntu 71.10% <58.82%> (+0.09%) ⬆️
windows 70.78% <58.82%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/util.go 0.00% <0.00%> (ø)
cmd/outputs.go 0.00% <0.00%> (ø)
output/cloud/cloud_easyjson.go 33.33% <ø> (ø)
output/cloud/data.go 90.97% <ø> (ø)
stats/csv/collector.go 83.83% <ø> (+0.67%) ⬆️
stats/influxdb/collector.go 81.30% <ø> (+1.49%) ⬆️
stats/kafka/collector.go 53.33% <ø> (+1.72%) ⬆️
stats/statsd/common/collector.go 82.71% <ø> (+0.78%) ⬆️
output/cloud/output.go 78.66% <64.93%> (ø)
js/runner.go 80.86% <0.00%> (-0.58%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44f5dc...cea5a0d. Read the comment docs.

mstoykov
mstoykov previously approved these changes Mar 4, 2021
@na-- na-- changed the title [WIP] Move the cloud output to the new Output interface Move the cloud output to the new Output interface Mar 4, 2021
@na--
Copy link
Member Author

na-- commented Mar 4, 2021

This is now ready for merging from my side, I've renamed all Collector / c mentions to Output / out, and I've cleaned up some of the linter issues that were present. I suggest reading the changes commit by commit.

@na-- na-- merged commit 57f7244 into master Mar 4, 2021
@na-- na-- deleted the move-cloud-output-to-new-interface branch March 4, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup cloud collector anonymous
3 participants