-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the cloud output to the new Output interface #1874
Conversation
005ebac
to
0efcf86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually just checked 2 or 3 things I wasn't sure about with the config and a thing that definitely doesn't work is picking up my subscription from the config file
0efcf86
to
a67b3a1
Compare
a67b3a1
to
7d50a9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 71.03% 71.16% +0.13%
==========================================
Files 183 183
Lines 14316 14306 -10
==========================================
+ Hits 10169 10181 +12
+ Misses 3530 3497 -33
- Partials 617 628 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is now ready for merging from my side, I've renamed all |
Follow up to #1869 and #1870. Closes #1258 and moves the cloud output to the new
Output
interface.