Split the cloud output so metric pushing is separate #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1905 +/- ##
==========================================
+ Coverage 71.19% 71.22% +0.03%
==========================================
Files 183 184 +1
Lines 14326 14337 +11
==========================================
+ Hits 10199 10212 +13
+ Misses 3501 3499 -2
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mstoykov
previously approved these changes
Mar 15, 2021
na--
force-pushed
the
cloud-output-split
branch
from
39c7df9 to
04028f8
Compare
mstoykov
previously approved these changes
Mar 15, 2021
imiric
previously approved these changes
Mar 15, 2021
na--
force-pushed
the
cloud-output-split
branch
from
b9f9487 to
005c657
Compare
|
Yes, though mostly so we can push metrics without initializing a full-blown |
mstoykov
approved these changes
Mar 15, 2021
imiric
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1857 and #1874