Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for building from source #2504

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Update instructions for building from source #2504

merged 2 commits into from
Apr 27, 2022

Conversation

JamieEdge
Copy link
Contributor

Updated the instructions for building from source to reflect the following:

  • Git should not be required where modules are proxied via proxy.golang.org, which is the default behaviour of Go.
  • Go installation instructions are now at go.dev instead of golang.org.
  • Go 1.17 is the minimum required version for k6 as specified in go.mod.
  • go install requires a version to be specified.
  • go install does not clone sources to $GOPATH/src.

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot requested review from na-- and oleiade April 23, 2022 11:02
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, and this well-deserved refresher of our README 👏🏻 I've left some comments, which, I believe, would improve the build from source instructions even further. Cheers 🎉

README.md Outdated Show resolved Hide resolved
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
@na-- na-- added this to the v0.38.0 milestone Apr 27, 2022
@na-- na-- merged commit bef4589 into grafana:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants